search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.02k stars 607 forks source link

Add doc URL to profile format and use it display help link. #888

Closed ghemawat closed 2 months ago

ghemawat commented 3 months ago

image

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.33%. Comparing base (0ed6a68) to head (5b49d6c). Report is 34 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #888 +/- ## ========================================== + Coverage 66.86% 67.33% +0.47% ========================================== Files 44 44 Lines 9824 9822 -2 ========================================== + Hits 6569 6614 +45 + Misses 2794 2761 -33 + Partials 461 447 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghemawat commented 2 months ago

This is now ready to review. Changes from prior commit:

  1. Rebased to pick up Go version changes.
  2. Added a small test to cover new code.
ghemawat commented 2 months ago

Will need another approval because of the comment change, sorry.

aalexand commented 2 months ago

@ghemawat We didn't add printing the link in the pprof CLI output, right? Should we add that too? E.g. the -top output has some summary information at the beginning, perhaps we should show the link there?

ghemawat commented 2 months ago

@ghemawat We didn't add printing the link in the pprof CLI output, right? Should we add that too? E.g. the -top output has some summary information at the beginning, perhaps we should show the link there?

Good point. I can do that in a bit. It is less useful since it doesn't show up as a clickable link, but might as well add it.