search

google / pprof

pprof is a tool for visualization and analysis of profiling data
Apache License 2.0
8.02k stars 607 forks source link

Update kernel base to work for non-KASLR kernels. #904

Closed gmarin13 closed 1 month ago

gmarin13 commented 1 month ago

Replace an existing check for "start >= loadSegment.Vaddr" with "start >= 0x8000000000000000".

The old condition was checking for the mapping start address to be greater or equal to the program segment Vaddr. However, for kernels without KASLR, the mapping start address (start) is less or equal the program header Vaddr. If the program header that includes the '.text' section is not the first segment, then the mapping start is strictly less than loadSegment.Vaddr.

Instead of removing the condition, we replace it with a check that start is in the kernel address space, so we don't take this path for user space binaries.

Adjusted the test case for PIE kernels to match actual addresses seen for a non-KASLR kernel. The new test fails with the old code and succeeds now.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.95%. Comparing base (0ed6a68) to head (a28ad78). Report is 47 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #904 +/- ## ========================================== + Coverage 66.86% 66.95% +0.09% ========================================== Files 44 44 Lines 9824 9857 +33 ========================================== + Hits 6569 6600 +31 - Misses 2794 2817 +23 + Partials 461 440 -21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.