google / process.dart

BSD 3-Clause "New" or "Revised" License
52 stars 26 forks source link

ProcessManager.start's first argument should be List<String> not List<dynamic> #10

Closed Hixie closed 1 year ago

Hixie commented 7 years ago

I'm implementing ProcessManager.start and I don't understand what type I could receive in the first argument's list other than String, nor what to do with any other types.

tvolkert commented 7 years ago

It's intentional - see https://github.com/google/process.dart/blob/master/lib/src/record_replay/command_element.dart

We could probably document that better in the interface.

Hixie commented 7 years ago

Ah, yeah, that should definitely be documented.

Should I be worrying about CommandElement in my mock for ProcessManager?

tvolkert commented 7 years ago

Nope

stuartmorgan commented 1 year ago

Closing, as this package now lives in flutter/packages. Please file an issue in the Flutter issue tracker if this is still an issue.