search

google / process.dart

BSD 3-Clause "New" or "Revised" License
52 stars 26 forks source link

Fix ProcessManager.canRun to be consistent with LocalProcessManager #62

Closed jmagman closed 3 years ago

jmagman commented 3 years ago

https://github.com/google/process.dart/pull/58 missed canRun. I hit this when I tried to migrate Flutter tool's ErrorHandlingProcessManager extends ProcessManager to null safety. https://github.com/flutter/flutter/blob/197b440e969841478d335d3fe5c6923bfb0e3a82/packages/flutter_tools/lib/src/base/error_handling_io.dart#L687

jmagman commented 3 years ago

I don't have permissions on this repo, @jonahwilliams @jamesderlin can you review?

jamesderlin commented 3 years ago

Oops. LGTM, but I don't have permissions on this repo either.