search

google / process.dart

BSD 3-Clause "New" or "Revised" License
52 stars 26 forks source link

ProcessManager.run* should throw ProcessException if executable not found #7

Closed tvolkert closed 1 year ago

tvolkert commented 7 years ago

As of https://github.com/google/process.dart/pull/3, it throws ArgumentError instead.

/cc @goderbauer

tvolkert commented 7 years ago

The native dart:io code throws the following:

ProcessException: No such file or directory
  Command: <cmd>

Whereas we're throwing:

Invalid argument(s): Cannot find executable for <cmd>
cedx commented 6 years ago

+1 for providing the ProcessException in this package.

tvolkert commented 6 years ago

@cedx you game to submit a PR? https://github.com/google/process.dart/blob/master/CONTRIBUTING.md

cedx commented 6 years ago

@tvolkert Done :smile:

stuartmorgan commented 1 year ago

Closing, as this package now lives in flutter/packages. Please file an issue in the Flutter issue tracker if this is still an issue.