google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 294 forks source link

Building Promises via Carthage fails due to SwiftLint errors #100

Closed cwalo closed 5 years ago

cwalo commented 5 years ago

carthage update --platform iOS fails with the following:

Build Failed
    Task failed with exit code 65:
    /usr/bin/xcrun xcodebuild -workspace /Users/MyName/Development/CDVisor/MyApp/Checkouts/promises/Promises.xcworkspace -scheme Promises -configuration Release -derivedDataPath /Users/MyName/Library/Caches/org.carthage.CarthageKit/DerivedData/10.1_10B61/promises/1.2.7 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/46/csbc0b4n54j0sdp9prmp_dqh0000gn/T/promises SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/MyName/Development/CDVisor/MyApp/Checkouts/promises)

the xcodebuild log shows:

...
/Users/MyName/Development/MyApp/Carthage/Checkouts/promises/Sources/Promises/Promise+Any.swift:153:8: error: Identifier Name Violation: Enum element name should only contain alphanumeric characters: 'value(_:)' (identifier_name)
/Users/MyName/Development/MyApp/Carthage/Checkouts/promises/Sources/Promises/Promise+Any.swift:154:8: error: Identifier Name Violation: Enum element name should only contain alphanumeric characters: 'error(_:)' (identifier_name)
Linting 'Promise+Delay.swift' (41/44)
Linting 'Promise+Then.swift' (42/44)
Linting 'Promise+Wrap.swift' (43/44)
Linting 'Contents.swift' (44/44)
Done linting! Found 2 violations, 2 serious in 44 files.

** ARCHIVE FAILED **

The following build commands failed:
    PhaseScriptExecution Run\ Script /Users/MyName/Library/Caches/org.carthage.CarthageKit/DerivedData/10.1_10B61/promises/1.2.7/Build/Intermediates.noindex/ArchiveIntermediates/Promises/IntermediateBuildFilesPath/Promises.build/Release-iphoneos/Promises.build/Script-031D2CA721FEABB60028E3D1.sh
(1 failure)

Xcode: 10.1 Carthage: 0.32.0 Swift: 4.2

shoumikhin commented 5 years ago

Hi Corey,

No idea what caused the issue on your side.

Perhaps some custom changes you may have made or an obsolete version of SwiftLint?

As a quick fix, try to check the following checkbox:

screen shot 2019-03-05 at 8 19 25 pm

Or remove that SwiftLint run script phase completely.

Thanks.

ghost commented 5 years ago

Hi Corey, if you are still seeing a build failure, please reopen this issue. Thank you!