search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 294 forks source link

Swift 5 #105

Closed kimdv closed 5 years ago

kimdv commented 5 years ago

Resolved #104

shoumikhin commented 5 years ago

Thanks! We'll merge this once we confirm it's safe to do so.

WyattMufson commented 5 years ago

@shoumikhin any idea when this will be merged in?

shoumikhin commented 5 years ago

Hi Wyatt,

Typically, it takes about 2 weeks to make a new major Xcode release adopted across Google’s infrastructure. Then we need to make sure all the apps built with Promises and Swift 5 work as expected. But the process may move faster or slower, I cannot really predict the exact timing.

Are you somehow blocked on us not switching to 5 immediately? Doesn’t seem there’re any code changes, perhaps you could patch this PR with version upgrade locally at the moment if that’s important for you to move forward?

Thanks.

WyattMufson commented 5 years ago

@shoumikhin no worries at all. Not blocked at all, was just curious. Thanks for the detailed explanation, appreciate it.

ghost commented 5 years ago

We are still looking to update to Swift 5 as soon as possible; however, there's a Bazel issue with Xcode 10.2 that's blocking the update. It appears the issue should be resolved in Bazel 0.25.0.

kimdv commented 5 years ago

Thanks a lot @temrich ! 🚀

ghost commented 5 years ago

@kimdv I've updated Travis to Bazel 0.25 and Xcode 10.2 and the build passes. So you should be good to update this PR and rerun the Travis build. Thank you for your help with migrating to Swift 5!

kimdv commented 5 years ago

@temrich rebased and pushed ✅

ghost commented 5 years ago

Thank you!