search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.81k stars 296 forks source link

CocoaPods and Swift? #11

Closed kenlaws closed 6 years ago

kenlaws commented 6 years ago

The instructions seem to explicitly exclude the idea of adding this via CocoaPods and using it with Swift. Is this the case? I gave it a shot and was told,

Could not build Objective-C module 'FBLPromises'

shoumikhin commented 6 years ago

Thank you for filing the issue, Ken!

We've been wrangling with CocoaPods for a few days already, and still couldn't come up with a proper Spec for Swift that wouldn't also break Bazel and Swift PM.

We've filed an issue on CocoaPods and are looking forward for any suggestions from the community. It has more details about the issues we're facing. We'll definitely keep you posted on the progress.

Thanks.

kenlaws commented 6 years ago

Thank you for the reply.

Hmmm. So I'm not crazy. There actually is an issue. How refreshing!

ehyche commented 6 years ago

I am facing the same issue. My Podfile looks like:

platform :ios, '9.0'

target 'GooglePromises' do
  use_frameworks!

  # Pods for GooglePromises
  pod 'PromisesObjC', '~> 1.0'
end

and when I do a "pod install", then open the workspace, and build, then it builds OK. But once I include:

import FBLPromises

into one of my project Swift files, then I get the compilation error:

'DotSyntax/FBLPromise+DotSyntax.h': file not found

at line 17 in FBLPromise+DotSyntax+All.h

ghost commented 6 years ago

Any updates on this ?

bigbangbear commented 6 years ago

whether platform support ios 8?

shoumikhin commented 6 years ago

Hey guys, thanks a lot for your patience and sorry for the delay!

Hopefully, we've finally got CocoaPods support for Swift now. Please refer the docs and close the issue once you confirm everything works properly. Or reply here if you still experience issues.

Regarding iOS 8, the only dependency Promises has is GCD and some basic containers from Foundation, so I don't think there're any real limitations on what version of iOS we can potentially support. We specify 9.0 in podspec just because it seems old enough. Let us know if that's a concern for you and we can think about adjusting it to older versions.

Thanks.

ghost commented 6 years ago

Hey everyone, Was able to successfully install the 'PromisesSwift' pod into an all Swift project. Will go ahead and close this issue.

Thanks again for everyone's patience!