Make FBLPromise.pendingObjects access threadsafe

eric commented 4 years ago

Swift uses the NSMutableSet to hold on to references of Swift promises but the modifications must be synchronized.

This is intended to fix #141.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

eric commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

eric commented 4 years ago

When I try to move it under FBLPromise+Testing.h it gives me a warning that it wants me to implement it in FBLPromise+Testing.m. Should I do that?

eric commented 4 years ago

I've updated based on comments.

eric commented 4 years ago

Huh... the tests were passing for me. I wonder what’s going on.

shoumikhin commented 4 years ago

You can find the details on Travis CI

eric commented 4 years ago

I realized I was only running the Swift tests and not Objective-C ones. This should be better now.

eric commented 4 years ago

Haha. Would you rather I get rid of the checks or just keep them?

shoumikhin commented 4 years ago

Feel free to remove them as the property is already gone.

eric commented 4 years ago

I've removed it. It should be ready to merge.

google / promises