search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 295 forks source link

Bump version to 1.2.9. #146

Closed ykjchen closed 4 years ago

ykjchen commented 4 years ago

@tristane0 @shoumikhin Does this look complete?

shoumikhin commented 4 years ago

Love it!

ghost commented 4 years ago

Looks good, thank you!

We also reference the latest release here: https://github.com/google/promises/blob/master/g3doc/index.md#swift-package-manager

But maybe we could generalize that reference so that we don’t have to update that file for each new release?

ykjchen commented 4 years ago

Good idea, updated docs to reference latest minor version.

ykjchen commented 4 years ago

FYI encountered some errors during pod lib lint, still need to resolve before tagging and pushing to trunk.

sushichop commented 4 years ago

@ykjchen

I investigated pod lib lint error. I think #145 and #148 need be merged to fix pod lib lint error about PromisesObjC.podspec at least.

Could you see that? Then try pod lib lint PromisesObjC.podspec

Thanks in advance.

ykjchen commented 4 years ago

@shoumikhin @tristane0 I'm trying to push to trunk and seeing:

... are not allowed to push new versions for this pod. The owners of this pod are ...

Are either of you able to add me as an owner?

pod trunk add-owner ...

https://guides.cocoapods.org/making/getting-setup-with-trunk.html