Resolve Xcode 12 minimum iOS version warnings

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.

Apache License 2.0

3.8k stars 295 forks source link

Resolve Xcode 12 minimum iOS version warnings #162

Closed paulb777 closed 4 years ago

paulb777 commented 4 years ago

Xcode 12 generates build warnings for iOS versions less than 9. More context at CocoaPods/CocoaPods#9884.

I confirmed that the macos and tvos versions are still ok in Xcode 12.

ykjchen commented 4 years ago

Thanks @paulb777.

Question: will this break consumers who still deploy to iOS 8? I'm guessing they would still be able to override this via post_install scripts?

I'll move forward with this in either case, since iOS 8 usage looks low.

paulb777 commented 4 years ago

Actually, I believe CocoaPods will prevent the install if iOS 8 is requested and instead install an earlier promises version. However, the iOS 8 usage is so low and now impossible to develop/test with Xcode 12 seems to justify the change to eliminate the warning.

Thanks for the merge.