Move dispatch_after and dispatch_group_async to class methods

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.

Apache License 2.0

3.79k stars 291 forks source link

Move dispatch_after and dispatch_group_async to class methods #197

Closed noahric-at-google closed 1 year ago

noahric-at-google commented 1 year ago

This PR moves dispatch_after and dispatch_group_async to class methods, so a subclass of FBLPromise could override the dispatch behavior (with access to FBLPromisePrivate.h).

Also updates a few other places to:

Use [self alloc] or [[self class] alloc] instead of [FBLPromise alloc], to make sure methods are allocating the same class as the instance (or class)
Use [FBLPromise class] in isKindOfClass: still, to not force exact subclass matching

noahric-at-google commented 1 year ago

Sorry, still working out some kinks, I'll open a new one when this is ready. Thanks!