search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 295 forks source link

Rename generic to avoid shadowing error #219

Closed ellishg closed 1 year ago

ellishg commented 1 year ago

When building with the latest upstream Swift I get several errors like:

src/Sources/Promises/Promise.swift:19:32: error: generic parameter 'Value' shadows generic parameter from outer scope with the same name; this is an error in Swift 6
  public typealias ObjCPromise<Value: AnyObject> = FBLPromise<Value>
                               ^
src/Sources/Promises/Promise.swift:18:28: note: 'Value' previously declared here
public final class Promise<Value> {
                           ^

This pull request should fix these errors (with no functional changes) by renaming the shadowing generics.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

chuckhays commented 1 year ago

Thanks for the fix!