search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.79k stars 291 forks source link

Fix SwiftUI previews crashes when Promises is statically linked. #221

Closed ykjchen closed 11 months ago

ykjchen commented 11 months ago

Targets #189 by applying the fix suggested in https://github.com/google/promises/issues/189#issue-1275085478

ykjchen commented 11 months ago

@paulb777 could you PTAL? Thanks!

ykjchen commented 11 months ago

I assumed the +Testing category doesn't need to be included. Please let me know if it does.

chuckhays commented 11 months ago

LGTM

paulb777 commented 11 months ago

The changes look good to me. @ncooke3, would you check if it fixes https://github.com/firebase/firebase-ios-sdk/issues/8005

paulb777 commented 11 months ago

Our testing is showing an issue. It may be related to not including +Testing. We'll verify and let you know.