search

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 295 forks source link

Version 2.4.0 not compiling #228

Open Nonouf opened 7 months ago

Nonouf commented 7 months ago

The latest update 2.4.0 isn't compiling... There are plenty of errors Type 'DispatchQueue' has no member 'promises'.

It's very problematic as the Firebase SDK is dependant on Promises 2.1.0 to 2.9.9.

shreyash-sharechat commented 7 months ago

+1, started failing for us when dependency resolution took version 2.4.0, without any code changes since prior release.

KN-Pradeep commented 7 months ago

+1, We tried to explicitly include the 2.3.1 version but due to other framework dependencies, it will also pick latest one and it leads to duplicate files.

chuckhays commented 7 months ago

Are you able to share a repro project? I'm trying to reproduce the problem but haven't been able to yet.

KN-Pradeep commented 7 months ago

Since it is a private repo, I can give the scenario in which it is failing, This issue we are facing w.r.t 2 repositories.

  1. We added Firebase as SPM and wanted to update version to use Firestore.

  2. In other repo our CI ran successfully on same branch earlier and it is failing with below reasons `❌ /Users/builder/clone/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/promises/Sources/Promises/Promise+All.swift:26:30: type 'DispatchQueue' has no member 'promises'

    on queue: DispatchQueue = .promises, ^

❌ /Users/builder/clone/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/promises/Sources/Promises/Promise+All.swift:41:30: type 'DispatchQueue' has no member 'promises'

on queue: DispatchQueue = .promises,`

HarshitParakh commented 7 months ago

+1. Facing the same issue. 2.4.0 isn't compiling...

ncooke3 commented 7 months ago

What Swift version is being used? swift -v

shreyash-sharechat commented 7 months ago

What Swift version is being used? swift -v

XCode 15.2

Apple Swift version 5.9.2 (swiftlang-5.9.2.2.56 clang-1500.1.0.2.5)
Target: arm64-apple-macosx14.0
elkhoudiry commented 7 months ago

Also i'm facing a problem on the CI because it's downloading the latest version 2.4.0 it's failing with this error Error: Signing for "Promises_Promises" requires a development team. Select a development team in the Signing & Capabilities editor. (in target 'Promises_Promises' from project 'Promises')

building for iOS 16.2 and xcode 14.2

Eventhough a development team is selected and pipeline was working ok before signing and building the application and uploading it to appstore connect

Nonouf commented 7 months ago

I just uploaded an example project here https://github.com/Nonouf/TestTuistFirebase You can simply open the workspace and compile to get the errors.

HarshitParakh commented 7 months ago

+1. Facing the same issue. 2.4.0 isn't compiling...

Any update here ?

ykjchen commented 7 months ago

Hey thanks for the reports. Is anyone experiencing this who isn't using Tuist? Or is this isolated to Tuist users?

JohnnyTseng commented 7 months ago

I am also having this issue, but I also use Tuist, too. @Nonouf Which version of tuist are you using? I am still on 3.41.0

FWJulien commented 7 months ago

Hey thanks for the reports. Is anyone experiencing this who isn't using Tuist? Or is this isolated to Tuist users?

I am experiencing the same issue as @elkhoudiry on Bitrise CI with XCode 15.0.1 building for iOS 15, not using Tuist.

elkhoudiry commented 7 months ago

Hey thanks for the reports. Is anyone experiencing this who isn't using Tuist? Or is this isolated to Tuist users?

It's happening with me on GitHub Actions CI

JohnnyTseng commented 7 months ago

Folks having issue with Tuist should try upgrade to Tuist 4 according to this: https://github.com/tuist/tuist/issues/6036#issuecomment-1980849357