Increase waitForPromise timeout in Testing section

[SRozhina]

Hi, I've just used Promises in unit tests with Xcode 9.4.1 (MacBook Air 2016). I tried to use your example and it didn't work for me:

@testable import Promises

// ...
func testExample() {
  // Arrange & Act.
  let promise = Promise<Int> { 42 }

  // Assert.
  XCTAssert(waitForPromises(timeout: 1))
  XCTAssertEqual(promise.value, 42)
  XCTAssertNil(promise.error)
}
// ...

I got an assertion error on the waitForPromises line. It is strange because there is no operations that could take up to 1 second. Anyway when I tried to increase the timeout to waitForPromises(timeout: 2) the test was passed.

Am I missing something here? If this is expected behaviour, here is PR that updates the timeout in docs

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[shoumikhin]

Hi Sophia, thank you for the heads up!

Does that happen when you run that test exclusively? Does it happen consistently with 1 second timeout, but when you increase it everything passes?

[SRozhina]

Thank you for so quick response, Yes, it happens when I run the test exclusively. And the test passes when I increase the timeout.

What is more interesting is when I run the following test suite (with two similar tests) first test gets "red" and the second gets "green":

class TestSuite: XCTestCase {
    func testExample() {
        // Arrange & Act.
        let promise = Promise<Int> { 42 }

        // Assert.
        XCTAssert(waitForPromises(timeout: 1))
        XCTAssertEqual(promise.value, 42)
        XCTAssertNil(promise.error)
    }

    func testExample2() {
        // Arrange & Act.
        let promise = Promise<Int> { 42 }

        // Assert.
        XCTAssert(waitForPromises(timeout: 1))
        XCTAssertEqual(promise.value, 42)
        XCTAssertNil(promise.error)
    }
}

[shoumikhin]

Hi Sophia, I'm still unable to reproduce your issue. May you please zip an Xcode project with all sources where the tests fail for you and attach here? Thanks!

[SRozhina]

I've tried to create new test project and run tests from previous comment. And they were passed. So I think there is conditions for tests' failure in my project. You could try to reproduce. Try to run one of the next tests from FullEventPresenterTests -> testPresenterTryToGetSimilarEventWhenTheyAreAlreadyFetched or testPresenterTryToFetchEventsWhereThereIsNoSimilar

[shoumikhin]

Hi Sophia,

All tests in your project passed for me with 1 sec timeout on Xcode 9.4.0, except testPresenterAllEventsLoaded, which requires at least 2 secs to wait for promises created in presenter.setup() since you explicitly asyncAfter 2 secs in searchEvents.

By the way, instead of that Cancelable wrapper you may consider extending a Promise class itself, like so:

enum CancellableErrors: Error {
  case cancelled
}

extension Promise {
  public func cancel() {
    reject(CancellableErrors.cancelled)
  }
}

Just so you can then use the promise directly anytime.

Let us know if you still have any issues with waitForPromises(). Thanks!

[ghost]

Closing for now. Please reopen if this is still an issue. Thank you!