Closed umdemir closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I've signed the CLA.
CLAs look good, thanks!
Thank you, Umit! Curious why you preferred setting that flag for the two framework targets only, but not for the whole project, so that all other targets inherit it?
I didn't want to touch the test projects because I assumed they're not going to run in a app extension or a real device. Actually it probably wouldn't hurt to set it on the project level. That way new targets would also inherit it without any changes. I think I'd like to set it on the project level now if it's ok with you too :) Thanks for the question!
…argets (Promises and FBLPromises) to clear out the 'ld: warning: linking against a dylib which is not safe for use in application extensions' warning