Fix ObjCBool/Bool compile error

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.

Apache License 2.0

3.81k stars 295 forks source link

Closed jonathanekim closed 6 years ago

jonathanekim commented 6 years ago

Fixes build with Swift 4.0 and 3.2 (Xcode 9.0) and 4.1 and 3.3 (Xcode 9.4).

Also moves the Swift version from Promises and PromisesTests to the Xcode project itself.

googlebot commented 6 years ago

CLAs look good, thanks!

jonathanekim commented 6 years ago

Interesting to note the slight difference between what worked here and https://github.com/realm/SwiftLint/pull/2038/commits/133cef8df1af0e9c4a8efc98a2ce63f39c530f72 (the !swift(>=4.1) vs swift(>=4.1)).

shoumikhin commented 6 years ago

Super cool! 👍