google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.
Apache License 2.0
3.8k stars 293 forks source link

Adds all() that accepts 4 heterogenous values #62

Closed EthanLozano closed 6 years ago

EthanLozano commented 6 years ago

Fixes #61

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
EthanLozano commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

EthanLozano commented 6 years ago

I'm not too proud of this code since it is just copy-pasted from the heterogeneous 3 version. But, it wasn't immediately obvious how I could have code re-use, so I just went with a quick and dirty solution.