migrate to Swift 4.2 - Githubissues

google / promises

Promises is a modern framework that provides a synchronization construct for Swift and Objective-C.

Apache License 2.0

3.8k stars 293 forks source link

migrate to Swift 4.2 #72

Closed koenpunt closed 5 years ago

koenpunt commented 5 years ago

When using Promises in a Xcode 10 project, it warns about that the target Promises can be updated to Swift 4.2. But this doesn't really work since its code is located in the cocoapod.

By updating the project it should no longer warn about this.

koenpunt commented 5 years ago

Oh bummer, I only looked at the issues, not at PRs, and now I see #70 already did (almost) the same as I did.

ghost commented 5 years ago

Hey Koen, thank you for the PR and sorry for the delayed reply. We are working on updating Travis to Xcode 10 and updating the Swift version from 4.0 to 4.2 in PR93. Would like to keep the Xcode and Swift version updates in the same PR.

Thank you!