Update docs about all(...) rejection logic

shali3 commented 5 years ago

I added this since it is not clear from the docs what happens in case of failure.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

shali3 commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

shali3 commented 5 years ago

ERROR: error loading package '': Unable to load file '@build_bazel_rules_apple//apple:swift.bzl': file doesn't exist
INFO: Elapsed time: 4.552s
INFO: 0 processes.
ERROR: Couldn't start the build. Unable to run tests
The command "bazel --batch test Tests --spawn_strategy=standalone --genrule_strategy=standalone --test_strategy=standalone --noshow_progress --noshow_loading_progress --verbose_failures --test_verbose_timeout_warnings --test_output=errors" exited with 1.

I think you have a problem with your build.

shoumikhin commented 5 years ago

Hi ShaLi,

Thank you for the PR!

Where does that error come from? Could you try upgrading your bazel version to 0.20 and applying the following patch?

Thanks.

shali3 commented 5 years ago

Done

shoumikhin commented 5 years ago

By the way, you may like the wording we used for inline comments.

shali3 commented 5 years ago

SGTM, updated.

ghost commented 5 years ago

Thank you, ShaLi, for the PR. Really appreciate it!

google / promises