Closed shali3 closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
CLAs look good, thanks!
ERROR: error loading package '': Unable to load file '@build_bazel_rules_apple//apple:swift.bzl': file doesn't exist
INFO: Elapsed time: 4.552s
INFO: 0 processes.
ERROR: Couldn't start the build. Unable to run tests
The command "bazel --batch test Tests --spawn_strategy=standalone --genrule_strategy=standalone --test_strategy=standalone --noshow_progress --noshow_loading_progress --verbose_failures --test_verbose_timeout_warnings --test_output=errors" exited with 1.
I think you have a problem with your build.
Hi ShaLi,
Thank you for the PR!
Where does that error come from? Could you try upgrading your bazel version to 0.20 and applying the following patch?
Thanks.
Done
By the way, you may like the wording we used for inline comments.
SGTM, updated.
Thank you, ShaLi, for the PR. Really appreciate it!
I added this since it is not clear from the docs what happens in case of failure.