Closed nzhuk closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
Googlers can find more info about SignCLA and this PR by following this link.
I signed it!
Hi Nikita, Thank you for the PR! Do you mind adding the following for each target in the xcodeproj to ensure that everything works for iOS, watchOS, tvOS, and macOS?
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; "LD_RUNPATH_SEARCH_PATHS[sdk=macosx*]" = "$(inherited) @executable_path/../Frameworks @loader_path/../Frameworks";
It appears that iOS, watchOS, and tvOS use @executable_path/Frameworks
; whereas, macOS uses @executable_path/../Frameworks
.
Thank you!
Thank you for the update!
My pleasure. Thanks for great framework!
The previous value -
$(TOOLCHAIN_DIR)/usr/lib/swift/macosx
- caused the built framework binary to have the followingotool -l
output:This caused errors during binary upload to the app store. In particular, App Store Connect sent an e-mail with the following error message:
This same error can be also seen by making Xcode archive export while having app thinning and bitcode compilation enabled:
Output:
I contacted Apple through DTS program, and their recommendation was to use
@executable_path/Frameworks
as value for theRunpath Search Paths
build setting.