search

google / proto-lens

API for protocol buffers using modern Haskell language and library patterns.
https://google.github.io/proto-lens
BSD 3-Clause "New" or "Revised" License
460 stars 110 forks source link

Relax text bounds to allow text-2.0 #433

Closed blackgnezdo closed 2 years ago

blackgnezdo commented 2 years ago

This was tested by using an explicit override with this diff:

--- a/stack-9.2.yaml
+++ b/stack-9.2.yaml
@@ -21,5 +21,10 @@ packages:
 - proto-lens-tests
 - proto-lens-tests-dep

+extra-deps:
+  - text-2.0
+  - Cabal-3.6.3.0@sha256:ff97c442b0c679c1c9876acd15f73ac4f602b973c45bde42b43ec28265ee48f4,12459
+  - parsec-3.1.15.0@sha256:a162d4cc8884014ba35192545cad293af0529fe11497aad8834bbaaa3dfffc26,4429
+
 ghc-options:
   "$locals": -Wall -Werror
blackgnezdo commented 2 years ago

text-2.0 will be in ghc-9.4, so I might as well front-load this boundary relaxation since I'm in the area.

blackgnezdo commented 2 years ago

@brandon-leapyear if you have some time, could you check if I'll cover everything by releasing these packages:

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

At the very least, that's all that my company uses :). A quick search of Hackage indicates that that seems correct

brandon-leapyear commented 2 years ago

:sparkles: This is an old work account. Please reference @brandonchinn178 for all future communication :sparkles:

FYI @blackgnezdo proto-lens is unique in that most other packages don't need to be released for us to be able to use it; stack.yaml allows specifying github repos with commits as dependencies instead of going to Hackage. But Stack has issues doing the same with the proto-lens git repo: https://github.com/commercialhaskell/stack/issues/5603

So in general, releasing proto-lens is more urgent than other packages because it's impossible to depend on it unless it's on Hackage