search

google / protobuf-gradle-plugin

Protobuf Plugin for Gradle
Other
1.77k stars 273 forks source link

Delete eclipse idea #619

Closed rougsig closed 1 year ago

rougsig commented 2 years ago

Background Our plugin uses a deprecated API to configure IDEs. Actually the logic of the IDEs is to take the source declared in the gradle source sets. They do it well, we don't need to add additional configuration to the IDEs on our plugin side.

Changes Remove IDEs support logic. IDEs support still exists, from gradle side.

Test plan Green pipelines. IDEs still know about source sets.

References https://github.com/gradle/gradle/issues/22233 https://github.com/JetBrains/intellij-community/blob/master/plugins/gradle/testSources/org/jetbrains/plugins/gradle/util/GradleContentRootContributorTest.java

rougsig commented 2 years ago

It's ready, but I'd rather leave it for the 0.10.0 release.

ejona86 commented 1 year ago

With https://github.com/google/protobuf-gradle-plugin/pull/636 this may be even easier, as we can create the folders earlier because we don't have to wait for the configuration to complete.

(I'm not saying to change this PR, but that once both the PRs are merged we could move the mkdir())