search

google / protobuf-gradle-plugin

Protobuf Plugin for Gradle
Other
1.77k stars 273 forks source link

Set default command length limit to 64k #653

Closed karthikrg closed 1 year ago

karthikrg commented 1 year ago

Various operating systems impose command length limits that are far short of the current Integer.MAX_VALUE default. For example, on MacOS 12.6.2, getconf ARG_MAX returns 1048576.

Hence set a reasonable default command line length limit of 64k.

rougsig commented 1 year ago

cc https://github.com/google/protobuf-gradle-plugin/issues/633

karthikrg commented 1 year ago

@rougsig do you know why my test is failing. It says internal error and I don't seem to have access to check more?

rougsig commented 1 year ago

One moment.

rougsig commented 1 year ago

No logs. Looks like github problem. Restarted it.

karthikrg commented 1 year ago

@rougsig I fixed the test and the codenarc failure, can you please rerun the workflow?

rougsig commented 1 year ago

@karthikrg done

karthikrg commented 1 year ago

@rougsig Thank you. All checks passed. If it looks ok, can you review please?