search

google / protobuf-gradle-plugin

Protobuf Plugin for Gradle
Other
1.77k stars 273 forks source link

Do not use GenerateProtoTask as source of output dirs information (3/3) #670

Open rougsig opened 1 year ago

rougsig commented 1 year ago

Background To prevent eager task configuration for android, we need to know the list of output folders from generate proto task.

Changes Use GenerateProtoTaskSpec as the source of trust for agp plugin. Just replaced usage of GenerateProtoTask to GenerateProtoTaskSpec

Test plan Green pipelines. No eager task configuration for android plugin part. Special test case was added.

Note merge after https://github.com/google/protobuf-gradle-plugin/pull/669

In java part we still have eager tasks configuration, if project have idea or eclipse plugin

rougsig commented 1 year ago

final fix for https://github.com/google/protobuf-gradle-plugin/issues/643

rougsig commented 1 year ago

Do not forget to update readme.md files. Will be in extra PR 4/3