search

google / protobuf-gradle-plugin

Protobuf Plugin for Gradle
Other
1.77k stars 273 forks source link

Remove duplicate output source dir. #703

Closed csv8674xn closed 1 year ago

csv8674xn commented 1 year ago

Remove duplicate output source dir that breaks in android in source jar task.

When using the insertion point, custom plugin needs to use the same output directory as the code gen output directory from java/javalite. This causes other tasks to fail if it depends on the output source and duplicationStrategy is set to DuplicatesStrategy.FAIL

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ejona86 commented 1 year ago

Multiple plugins having the same output directory sounds like asking for trouble. Why are they being configured to have the same output directory?

karthikrg commented 1 year ago

Multiple plugins having the same output directory sounds like asking for trouble. Why are they being configured to have the same output directory?

@ejona86 Without using the same output directory we are not able to use insertion points to modify the code generated by the java/javalite plugin.

ejona86 commented 1 year ago

Oh, gosh, insertion points. Okay, yeah, that is at least worth a comment in the code as a reminder.

I'll note that it is generally a bad idea to use insertion points, but that is just useless advice if you are already using them as they are almost impossible to migrate away from.

csv8674xn commented 1 year ago

@ejona86 Two required tests failed to run and I don't see the project is configured to enable manual rerun(at least I can't find it) Those two failed with 0s and were passing before my styling fixes. Seem like a CI issue.

ejona86 commented 1 year ago

Looks like github is a bit unhealthy today. https://www.githubstatus.com/ . Restarting them worked (and yes, you don't have permission to do that).

csv8674xn commented 1 year ago

Thanks for merging the PR @ejona86. Do we have a regular release schedule to follow? Based on the past release timeline, it does not look like it was periodic.

csv8674xn commented 1 year ago

Thanks for merging the PR @ejona86. Do we have a regular release schedule to follow? Based on the past release timeline, it does not look like it was periodic.

@rougsig if you can share some information, that would be great. Thank you.

rougsig commented 1 year ago

There is no release cycle. The release published after adding functionality or fixing bugs.

csv8674xn commented 1 year ago

There is no release cycle. The release published after adding functionality or fixing bugs.

Do we anticipate releasing a version with this fix soon-ish? This is actually blocking the usage of AGP 8.0 if we use insertion point at the same time. Currently, there's no workaround of this issue until this change is released. @rougsig

rougsig commented 1 year ago

@YifeiZhuang Can we do a release?