Follow the pedantic static analysis options

google / protobuf.dart

Runtime library for Dart protobufs

https://pub.dev/packages/protobuf

BSD 3-Clause "New" or "Revised" License

533 stars 184 forks source link

Follow the pedantic static analysis options #195

Open srawlins opened 5 years ago

srawlins commented 5 years ago

This code should follow the pedantic static analysis options. I tried to do this myself, but apparently, the "include" directive in analysis_options.yaml does not work when it is in the parent directory of any pubspec.yaml (or maybe .packages, whatever). https://github.com/dart-lang/sdk/issues/35831.

osa1 commented 2 years ago

https://github.com/google/protobuf.dart/commit/52544ea07f04c0d53668ccf85e2370dd4bfda19c started using pedantic but it was reverted later with https://github.com/google/protobuf.dart/commit/45e054a26b0f1f9c9e7309cd679c6571b7db04d8.

Also, pedantic README says that it's deprecated, but it doesn't say what analysis settings Google projects (not Dart or Flutter) should use.

So I don't know what is the recommended analysis options for open-source Google libraries now. @srawlins do you know?

srawlins commented 2 years ago

The recommended set of lints is now https://github.com/dart-lang/lints/blob/main/lib/recommended.yaml