search

google / pull-request-mailer

Sends a GitHub pull request as a patch series via email
BSD 3-Clause "New" or "Revised" License
44 stars 15 forks source link

Add --reply-to feature. #20

Closed nh2 closed 9 years ago

nh2 commented 9 years ago

This allows setting the Reply-To header in the sent emails.

That's useful if the email address from which the emails are sent cannot be replied to. For example, if bot@example.com sends the email to a mailing list list@example.com and you want that people reply to the list and not to the bot, use --reply-to list@example.com.

nh2 commented 9 years ago

review @ppetr @aehlig

aehlig commented 9 years ago

LGTM

But in the future we might consider not adding more positional arguments to pullRequestToThreadServer. With two String arguments and three Maybe String arguments we start getting into the area where messing up the order of the arguments might become an issue.

ppetr commented 9 years ago

LGTM

I support the idea to move the positional arguments into a data type in the future.