google / pull-request-mailer

Sends a GitHub pull request as a patch series via email
BSD 3-Clause "New" or "Revised" License
44 stars 15 forks source link

Allow using env variable for passing credentials. Fixes #8. #9

Closed nh2 closed 9 years ago

nh2 commented 9 years ago

Passing PULL_REQUEST_EMAILER_GITHUB_OAUTH_TOKEN=mytoken as an environment variable is now an alternative to the --github-oauth-token=mytoken argument.

nh2 commented 9 years ago

review @ppetr

nh2 commented 9 years ago

review @ribag

ppetr commented 9 years ago

I'd suggest to remove the command line argument option completely so that users aren't given the less-secure choice.