google / python-adb

Python ADB + Fastboot implementation
Apache License 2.0
1.79k stars 357 forks source link

Fix downloading binary images to device #153

Closed penn5 closed 5 years ago

penn5 commented 5 years ago

BytesIO is used if no length is provided, so the correct type here is bytes. Also binary images are often flashed, and especially the Android bootimage header contains 0x80 which cannot be decoded in the default codec for 'r' type, which is default.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 43.567% when pulling 633fe32d801811d5217686161b894ab8548a2562 on penn5:patch-1 into d9b94b2dda555c14674c19806debb8449c0e9652 on google:master.

penn5 commented 5 years ago

I signed it.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.