search

google / python-adb

Python ADB + Fastboot implementation
Apache License 2.0
1.8k stars 357 forks source link

Open rsa key file with 'rb' to avoid TypeError #173

Closed ghost closed 2 years ago

ghost commented 4 years ago

It's similar to sign_pycryptodome.py and https://github.com/lyft/confidant/issues/202

It throws TypeError: from_buffer() cannot return the address of a unicode object for now

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 43.715% when pulling 339d80eefb7c583a54fa913b2ffc5cc735c2a327 on rokya:master into f4e597fe55900651a8a91fccc1e09061fd96b5e9 on google:master.

JeffLIrion commented 4 years ago

This issue, among others, is fixed in adb-shell.

https://github.com/JeffLIrion/adb_shell/blob/825294d9a4923b8857380b6b5b51a8937e91aa70/adb_shell/auth/sign_cryptography.py#L51-L56