google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.86k stars 1.44k forks source link

Update in setup.cfg: license-file -> license_files #423

Closed martenwa closed 1 year ago

martenwa commented 1 year ago

This happens both in version 0.5.0 and in master:

 * QA Notice: setuptools warnings detected:
 * 
 *  The license_file parameter is deprecated, use license_files instead.
 *  Usage of dash-separated 'license-file' will not be supported in future versions. Please use the underscore name 'license_file' instead
dbieber commented 1 year ago

Sounds good. Let's do the rename.

hugovk commented 1 year ago

In fact, it can be omitted entirely because setuptools automatically includes LICENSE:

A list of glob patterns for license related files that should be included. If neither license_file nor license_files is specified, this option defaults to LICEN[CS]E*, COPYING*, NOTICE*, and AUTHORS*.

https://setuptools.pypa.io/en/latest/references/keywords.html#keywords

Please see PR https://github.com/google/python-fire/pull/434.

dbieber commented 1 year ago

Closed by #434