search

google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.86k stars 1.44k forks source link

Fix path to requirements.txt #433

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

Follow on from https://github.com/google/python-fire/pull/431 to fix the CI.

Sample build: https://github.com/hugovk/python-fire/actions/runs/4068330039

Borda commented 1 year ago

wondering how that the PR #431 went :green_circle:

hugovk commented 1 year ago

Because it only ran the CLA check:

image

That was because the test workflow only triggered for push events, and for a push from a fork, means it would only run on the fork's CI, not this upstream:

on: [push]

It failed on https://github.com/google/python-fire/pull/428 because it fixes the triggers:

on: [push, pull_request]

So it also runs on upstream for the PR trigger. This is good, so we can see if PRs from forks pass on the CI. This is very important for open source, where people often contribute from forks.