google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.86k stars 1.44k forks source link

ci: watcher for automerge #435

Open Borda opened 1 year ago

Borda commented 1 year ago

As discussed in https://github.com/google/python-fire/pull/428#issuecomment-1413497193 adding a closure job would allow enabling automerge without need of updating branch protection checks when new Python version is added

Borda commented 1 year ago

now we could set these two as required checks: image cc: @hugovk

hugovk commented 1 year ago
image

👍

Borda commented 1 year ago

@dbieber any idea what is happening with the @copybara? as there are no details shared... :thinking:

dbieber commented 1 year ago

Copybara is the tool we use to sync the google internal copy of the repo with the github copy. The error could be from them getting out of sync; I'll have to look into that. You can ignore that check in the mean time.

Borda commented 1 year ago

@dbieber how is it going? :chipmunk:

Borda commented 1 year ago

@dbieber can I help with anything else here? :rabbit:

dbieber commented 1 year ago

Thanks for checking back in, but unfortunately no, no updates on my end.

Borda commented 1 year ago

Gentle ping @dbieber :chipmunk:

Borda commented 11 months ago

@dbieber how are you doing, still with this project? :chipmunk:

Borda commented 8 months ago

hello @dbieber, happy New year! :fireworks:

Borda commented 8 months ago

@dbieber any chance to get some more details on what is happening with the copybara?

dbieber commented 8 months ago

@dbieber any chance to get some more details on what is happening with the copybara?

Hmm, I don't know offhand. Copybara is a tool we use to sync our internal and external codebases. I'll have to investigate.

Borda commented 8 months ago

I'll have to investigate.

lets try just restart it for now?

dbieber commented 8 months ago

You can safely ignore it.

Borda commented 8 months ago

You can safely ignore it.

the rest is green :green_circle:

Borda commented 7 months ago

@dbieber, so can we merge it? :thinking:

dbieber commented 6 months ago

Hi Borda,

Thank you for the PR and your patience. I see the value of running the GitHub Actions on a pull_request. I do not see the value of the watcher job or auto-merge, however.

I understand that the watcher job would allow for auto-merge. Perhaps I am misunderstanding what auto-merge is, but it seems to me that I would like to review and approve PRs before they are merged, and hence I do not want to enable auto-merge on this project. Let me know if I'm misunderstanding auto-merge or missing something.

Cheers, David

🐙

Borda commented 6 months ago

I understand that the watcher job would allow for auto-merge.

That is probably a misunderstanding; the watcher jobs just aggregated the result over the previously completed matrix of jobs... so the case is that in the GH setting you do not need to click all jobs one by one and if you change Python version it need to be also updated in the setting but you set as required only this one which is aggregated result of all

Borda commented 4 months ago

@dbieber, mind having a look and sharing your thoughts? 🦩 this will also be even more useful if we extend the testing matrix, ref #490

Borda commented 1 month ago

@dbieber friendly ping if you could have a look... :chipmunk: