Open Borda opened 1 year ago
now we could set these two as required checks:
cc: @hugovk
👍
@dbieber any idea what is happening with the @copybara? as there are no details shared... :thinking:
Copybara is the tool we use to sync the google internal copy of the repo with the github copy. The error could be from them getting out of sync; I'll have to look into that. You can ignore that check in the mean time.
@dbieber how is it going? :chipmunk:
@dbieber can I help with anything else here? :rabbit:
Thanks for checking back in, but unfortunately no, no updates on my end.
Gentle ping @dbieber :chipmunk:
@dbieber how are you doing, still with this project? :chipmunk:
hello @dbieber, happy New year! :fireworks:
@dbieber any chance to get some more details on what is happening with the copybara
?
@dbieber any chance to get some more details on what is happening with the
copybara
?
Hmm, I don't know offhand. Copybara is a tool we use to sync our internal and external codebases. I'll have to investigate.
I'll have to investigate.
lets try just restart it for now?
You can safely ignore it.
You can safely ignore it.
the rest is green :green_circle:
@dbieber, so can we merge it? :thinking:
Hi Borda,
Thank you for the PR and your patience. I see the value of running the GitHub Actions on a pull_request. I do not see the value of the watcher job or auto-merge, however.
I understand that the watcher job would allow for auto-merge. Perhaps I am misunderstanding what auto-merge is, but it seems to me that I would like to review and approve PRs before they are merged, and hence I do not want to enable auto-merge on this project. Let me know if I'm misunderstanding auto-merge or missing something.
Cheers, David
🐙
I understand that the watcher job would allow for auto-merge.
That is probably a misunderstanding; the watcher jobs just aggregated the result over the previously completed matrix of jobs... so the case is that in the GH setting you do not need to click all jobs one by one and if you change Python version it need to be also updated in the setting but you set as required only this one which is aggregated result of all
@dbieber, mind having a look and sharing your thoughts? 🦩 this will also be even more useful if we extend the testing matrix, ref #490
@dbieber friendly ping if you could have a look... :chipmunk:
As discussed in https://github.com/google/python-fire/pull/428#issuecomment-1413497193 adding a closure job would allow enabling automerge without need of updating branch protection checks when new Python version is added