search

google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.86k stars 1.44k forks source link

Fix typos in console and tests #436

Closed yarikoptic closed 1 year ago

dbieber commented 1 year ago

Thanks for fixing the typos. Let's not add codespell at this time, but I'd be happy to merge the PR w/ just the typo fixes.

yarikoptic commented 1 year ago

You are the boss. I force pushed kicking away the last commit with the workflow. Let me know if you would like to get rid of .codespellrc as well

dbieber commented 1 year ago

Let me know if you would like to get rid of .codespellrc as well

Yep, thanks

yarikoptic commented 1 year ago

IMHO "your loss", but done now.

dbieber commented 1 year ago

Thanks Yari! I'm not opposed to adding spell check more generally; just adding codespell would require more research and review on my part and would delay getting things checked in. So, I'm happy to merge the pure-fix PR now rather than having an easy fix get blocked by a slower process.

yarikoptic commented 1 year ago

Understood. Let me know if your want sister pr with those