search

google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.86k stars 1.44k forks source link

Fix pandas.DataFrame support in core._PrintResult #446

Open paul-ada opened 1 year ago

paul-ada commented 1 year ago

Issue: When calling Fire on a function that returns a pd.DataFrame, the _PrintResult function in core.py prints the manual for DataFrames from the pandas Docs to stdout.

if value_types.HasCustomStr(result): doesn't recognize the DataFrame's custom __str as it is simply seemingly inherited from the custom __repr for DataFrames. See pandas.core.frame.DataFrame.__repr__ which calls .to_string()).

Due to this, the _PrintResult function displays the DataFrame's helptext.HelpText instead.

This implementation should fix the issue.

Edit: Only seeing now that there is a related issue: #274

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

dbieber commented 8 months ago

Thanks for the PR @paul-ada! It may be some time before we process it, but it is already appreciated.