search

google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.95k stars 1.44k forks source link

ci: expand build matrix for major OS #490

Closed Borda closed 2 weeks ago

Borda commented 7 months ago

I suggest including testing on Mac and Win. also, the addition of OS builds does not need to be so extensive and could be listed in the include section adding 3.8 as the oldest and 3.12 as the latest python version

Borda commented 5 months ago

@dbieber, mind having a look and sharing your thoughts? :flamingo:

Borda commented 2 months ago

@dbieber friendly ping if you could have a look... :chipmunk:

dbieber commented 2 weeks ago

I'm open to this!

Borda commented 2 weeks ago

I'm open to this!

@dbieber updated and resolved conflicts

dbieber commented 2 weeks ago

I'm seeing this error

[Invalid workflow file: .github/workflows/build.yml#L18](https://github.com/google/python-fire/actions/runs/10973863694/workflow)
The workflow is not valid. .github/workflows/build.yml (Line: 18, Col: 20): Unexpected value 'false'
Borda commented 2 weeks ago

I'm seeing this error

Let's go with @hugovk @dbieber if I won't need approval for each run, it would be great (faster)

dbieber commented 2 weeks ago

@dbieber if I won't need approval for each run, it would be great (faster)

It should run without approval now. 👍