search

google / python-fire

Python Fire is a library for automatically generating command line interfaces (CLIs) from absolutely any Python object.
Other
26.95k stars 1.44k forks source link

drop support for Py2 and Py3.4 #498

Open Borda opened 6 months ago

Borda commented 6 months ago

I am trying to address https://github.com/google/python-fire/issues/420#issuecomment-1989323528 cc: @hugovk if you would be so kind (as always you have been) and may help me, check I missed :rabbit:

hugovk commented 6 months ago

Why choose 3.5 as the lower bound? 3.8 is the lowest supported: https://devguide.python.org/versions/

Borda commented 6 months ago

Why choose 3.5 as the lower bound? 3.8 is the lowest supported: devguide.python.org/versions

O wpul;d do it too, but following setup.py which classifies support for 3.5, so we can do the additional bump in other/following PR if @dbieber agrees :flamingo:

a-detiste commented 6 months ago

The Great Six Cleanser are watching you https://wiki.debian.org/Python3-six-removal :-)

Borda commented 2 months ago

cc: @dbieber

dbieber commented 2 weeks ago

Thanks for putting this together. I'm going to try to get the Python 2 specific stuff out of the codebase now (airplane wifi permitting!). I'm likely going to treat the console code separately though since it's third_party code.

Borda commented 2 weeks ago

Thanks for putting this together. I'm going to try to get the Python 2 specific stuff out of the codebase now (airplane wifi permitting!). I'm likely going to treat the console code separately though since its third_party code.

sure, @dbieber so shall I continue with it?