google / python-temescal

Python control for LG speaker systems
Apache License 2.0
22 stars 17 forks source link

Add new equalisers, stream_types, play_ctrl_states #10

Open dunaparty opened 3 years ago

dunaparty commented 3 years ago

By using LG SP8YA (2021):

Fixes #9

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

dunaparty commented 3 years ago

@googlebot I signed it!

akinomeroglu commented 3 years ago

@mjg59 Hi, sorry to disturb you. Without this pr new modals broke in Home Assistant so can you kindly consider review it and make a new release?

Thanks a lot.

Syndlex commented 2 years ago

Hey, friendly reminder for this pr.

MasonCrawford commented 2 years ago

would love to see this get merge in soon @mjg59

bernimoses commented 2 years ago

@dunaparty can you add a new function ("E-ARC") so we can get this merged together (here is my tested patch)?

dunaparty commented 2 years ago

@dunaparty can you add a new function ("E-ARC") so we can get this merged together (here is my tested patch)?

Done.

MasonCrawford commented 2 years ago

@bernimoses is anything else blocking this PR from going in? can you approve the PR and mearge it?

bernimoses commented 2 years ago

@bernimoses is anything else blocking this PR from going in? can you approve the PR and mearge it?

Sorry i am not the maintainer. I think @mjg59 could merge it.

akinomeroglu commented 2 years ago

@bernimoses will you consider the fork this library and merge pr and then add new library to Home Assistant as a dependency?

MasonCrawford commented 2 years ago

@akinomeroglu if you get a fork up on pypi.org, i can update the home assistant Integration to use that as the dependency, it looks like this libary is not active

bernimoses commented 2 years ago

@bernimoses will you consider the fork this library and merge pr and then add new library to Home Assistant as a dependency?

Sorry i'm not much into python and i don't think that i can do a good job of maintaining this library.

MasonCrawford commented 2 years ago

@dunaparty i have been in contact with @mjg59, he no longer has access to approve this PR but is working getting access or this PR approved

MasonCrawford commented 2 years ago

FYI: temescal was updated and is now located at this link, this PR was added as part of this, https://github.com/mjg59/python-temescal

HA was updated to use the new version along with some other updates