search

google / qhbm-library

Quantum Hamiltonian-Based Models built on TensorFlow Quantum
https://qhbm-library.readthedocs.io/en/latest/
Apache License 2.0
40 stars 15 forks source link

Add yapf linter step and make CI explicit #116

Closed jaeyoo closed 2 years ago

jaeyoo commented 2 years ago

Fix https://github.com/google/qhbm-library/issues/44

Before this PR, CI only showed two steps only in this Conversation Tab.

Continuous Integration / Checks (pull_request) Failing after 5s 
cla/google Successful in 1s — ✅ All contributors are covered under a CLA with Google

This made us frustrated to check the real cause of the error because it's implicit. So, this PR makes the CI steps explicit in this Conversation tab, which also enables the parallel executions of the whole CI steps.

Also, it adds yapf linter

farice commented 2 years ago

omg you're so fast that I got whiplash!

would it make sense to fix whatever errors yapf raises in the same PR?

jaeyoo commented 2 years ago

Since there are so many lint errors, let me open a new PR to deal with it.

farice commented 2 years ago

sounds great, thanks for fighting the beast! looking forward to seeing the green checkmark! 💪

zaqqwerty commented 2 years ago

To ease the burden, is there a way to add an excludelist that initially has all the files, then we remove them one-by-one in PRs? (new files would not be added to the list)

jaeyoo commented 2 years ago

To ease the burden, is there a way to add an excludelist that initially has all the files, then we remove them one-by-one in PRs? (new files would not be added to the list)

That's a good idea. let me add the excludelist for linter, and defeat the lint errors one-by-one :)

jaeyoo commented 2 years ago

After PyPI recently changed their client webauth scheme (1 hr ago), poetry can't find packages for now. Let's wait for their patch...

jaeyoo commented 2 years ago

Done. may I merge this? @zaqqwerty