search

google / qhbm-library

Quantum Hamiltonian-Based Models built on TensorFlow Quantum
https://qhbm-library.readthedocs.io/en/latest/
Apache License 2.0
40 stars 15 forks source link

Loss function arguments are not used anywhere inside. #117

Closed jaeyoo closed 2 years ago

jaeyoo commented 2 years ago

pylinter complaints about the loss functions in vqt and qmhl.

************* Module qhbmlib.vqt
qhbmlib/vqt.py:40:11: W0613: Unused argument 'trainable_variables' (unused-argument)
************* Module qhbmlib.qmhl
qhbmlib/qmhl.py:39:11: W0613: Unused argument 'trainable_variables' (unused-argument)

Both codes are calling

  return loss(model.trainable_variables)   # vqt
  return loss(qhbm_model.trainable_variables)  # qmhl

But each loss doesn't use the argument inside at all

  def loss(trainable_variables):  # `trainble_variables` is unused anywhere
jaeyoo commented 2 years ago

This is just a lint issue because trainable_variables in QHBM is already bonded with ebm.trainable_variables and qnn.trainable_variables in qhbm.py. Let's just del it.