google / qhbm-library

Quantum Hamiltonian-Based Models built on TensorFlow Quantum
https://qhbm-library.readthedocs.io/en/latest/
Apache License 2.0
40 stars 15 forks source link

Hamiltonian tracing #156

Closed zaqqwerty closed 2 years ago

zaqqwerty commented 2 years ago

Resolves #154

farice commented 2 years ago

jfme: what fixed the test compared to what you had before? I guess it was just to initialize the symbol values non-randomly?

zaqqwerty commented 2 years ago

jfme: what fixed the test compared to what you had before? I guess it was just to initialize the symbol values non-randomly?

Two things:

  1. Changing the measured op so that the expectation values were different enough from zero (resolving the energy parameter test)
  2. Adding symbols to the circuit so that there were actually values to change (resolving the circuit parameter test)
farice commented 2 years ago

Thanks for the explanation, all is clear