google / qhbm-library

Quantum Hamiltonian-Based Models built on TensorFlow Quantum
https://qhbm-library.readthedocs.io/en/latest/
Apache License 2.0
40 stars 15 forks source link

Remove counts argument of QuantumCircuit methods #158

Closed zaqqwerty closed 2 years ago

zaqqwerty commented 2 years ago

Consider the expectation method of QuantumInference. The counts argument is used as the weight of the pure state expectation values. However, it is also used to set the number of samples used to estimate these individual expectation values. I want to consider pushing the unique bitstring logic down into the quantum circuit class, rather than having the caller need to worry about unique bitstrings. In particular, the new VQT logic does not let the counts of input bitstrings propagate into QuantumInference calls.