Closed zaqqwerty closed 2 years ago
Made a few changes to address your comments:
model
to models
, so we won't have to change the name when we add more in the futureinfer
to inference
qmhl_loss.py
and vqt_loss.py
to the inference
subpackagequantum_data.py
to the new data
subpackageQHBMData
into new module qhbm_data
to break a circular importAlso, decided to remove architectures
and hamiltonian
. Only one function is used within the library, get_hardware_efficient_model_unitary
, so I moved this into the test_util
file. Otherwise, the functions in architectures
and hamiltonian
were used only occasionally in research code, so if we were to keep any of it I think they only make sense in the baselines
directory. To this end I opened #197.
Left a comment on the discussion of adding __all__
to init files.
After our discussion, settled on package imports (from qhbmlib import inference
) throughout the test files, stuck with module imports (from qhbmlib.inference import qhbm
) in the library code files, which ends up being consistent with how things look to be done in TFP.
Part of #99
The number of files was causing imports to become tedious. This pull request creates two new submodules,
model
andinfer
, and moves related files into them. New__init__
files have been added to these modules to simplify user imports: for example, instead ofwe can now have
For a followup pull request, any opinions on where the remaining top-level files should go?