search

google / qkeras

QKeras: a quantization deep learning library for Tensorflow Keras
Apache License 2.0
533 stars 102 forks source link

Introducing quantized_linear #118

Closed mschoenb97 closed 1 year ago

mschoenb97 commented 1 year ago

New quantizer to replace quantized_bits. Summary of improvements from old version:

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

vloncar commented 1 year ago

Since this deprecates quantized_bits it would be useful to also note this in the main readme and update the jupyter examples. And since it is very impactful and important please consider tagging a release after merging so that packages dependent on qkeras have a new target from which they can expect this quantizer to exist. :pray:

mschoenb97 commented 1 year ago

Since this deprecates quantized_bits it would be useful to also note this in the main readme and update the jupyter examples. And since it is very impactful and important please consider tagging a release after merging so that packages dependent on qkeras have a new target from which they can expect this quantizer to exist. 🙏

Since this deprecates quantized_bits it would be useful to also note this in the main readme and update the jupyter examples. And since it is very impactful and important please consider tagging a release after merging so that packages dependent on qkeras have a new target from which they can expect this quantizer to exist. 🙏

I've updated this as requested. It looks like quantized_bits is in many locations other than the notebooks. Should I update this everywhere?

mschoenb97 commented 1 year ago

This is looking very good. Overall, I'm wondering if we really need all the special property decorators, and if it would simplify the code to remove some of them. However, this is more of a nit pick.

Got rid of all unneeded properties