Use `delta()` instead of `max() * 2^-bits` when `delta()` is defined

google / qkeras

QKeras: a quantization deep learning library for Tensorflow Keras

Apache License 2.0

533 stars 102 forks source link

Use `delta()` instead of `max() * 2^-bits` when `delta()` is defined #125

Open nghielme opened 10 months ago

nghielme commented 10 months ago

I'm working on floating point quantizer and I think this line doesn't work in my case: delta = self.quantizer.max() * 2**-self.quantizer.bits With the modification proposed one can define delta() in the quantizer class and use it instead of making the computation in the initializer.

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.