search

google / quiche

BSD 3-Clause "New" or "Revised" License
660 stars 132 forks source link

Commit about ECN break UDP socket platform impl #37

Closed martenrichter closed 1 year ago

martenrichter commented 1 year ago

I during my weekly tracking of the quiche library, I ran into an issue with the commit: Alter IP_TOS socket call for ECN based on platform.

It misses an implementation of GetEcnCmsgArgsPreserveDscpImpl in https://github.com/google/quiche/blob/main/quiche/common/platform/default/quiche_platform_impl/quiche_udp_socket_platform_impl.h Also in envoy, I think it is missing. It would be nice if a default implementation would be added, or a pointer to what it does so that I can implement it if a default implementation is not provided. Thanks! Marten

bencebeky commented 1 year ago

Thanks for the report. We have an automated standalone build that also detected the issue (but it is not yet set up to prevent such changes from being submitted). https://github.com/google/quiche/commit/9d12bde76d3c48fbd4b755312aa0759775f0cfdb should fix it.

martenrichter commented 1 year ago

Perfect, maybe Friday night is a bad time to automatically fetch the master branch...