search

google / quiver-log

Logging utility for Dart
Apache License 2.0
24 stars 14 forks source link

Add a polymer log viewer to quiver-log #2

Closed ChrisBWright closed 10 years ago

ChrisBWright commented 10 years ago

This is structured as a popup component and a static log viewer. The log viewer allows a person to view logs from a particular logger and filter them according to various criteria.

adambender commented 10 years ago

If we are gonna pull this into quiver-log (and I think it makes good sense to) it will need to conform a little better with the library setup we are using for quiver.log. I believe you will need something like log.dart included above the src dir. As far as the name goes, I wonder if 'log-viewer' isnt a more appropriate name than 'browser' for this directory given that the components are all some shade of 'log-viewer'. Also, perhaps most importantly it needs tests.

ChrisBWright commented 10 years ago

I haven't added a lib/logviewer.dart or anything like that yet. There seems to be no guidance available for how to structure polymer libraries. I can't import and export HTML or use a part of construct there.

I think the best idea I've seen is adding lib/components. With that, would you recommend putting logviewer.[dart|html] directly in lib/components, or making a subdirectory for it? Lower hierarchy seems better to me.

ChrisBWright commented 10 years ago

I've put logviewer into lib/components and added more tests. Anything else you want?

adambender commented 10 years ago

Sorry for the delay on this, got crushed in the last couple months with a new product launch. Im going to pull this in now but would love to see if we could refactor this so that the viewer uses the appender framework in library.