google / rappor

RAPPOR: Privacy-Preserving Reporting Algorithms
Apache License 2.0
862 stars 163 forks source link

Addressing boolean RAPPOR decode failures when TRUE is ~ 0. #56

Closed ananthr closed 8 years ago

ananthr commented 8 years ago

New function .DecodeBoolean outputs an estimate for TRUE directly from EstimateBloomCounts; bypassing maps and LASSO.

This fixes a few errors that arise when the underlying distribution for TRUE is very close to zero and maps + LASSO fails to recover "a candidate solution."

ilyamironov commented 8 years ago

Since this change is introduced to address a specific bug, it'd be a good idea to add a corresponding test to decode_test.R.

andychu commented 8 years ago

LGTM

OK thanks for fixing this, go ahead and merge and I can update the pipeline.